- Jan 15, 2024
-
-
chen yuanjian authored
Change-Id: I7de6775e230c68505bbc22ac7b8000ebfd0204e4
-
- Jul 22, 2021
-
-
Android Build Coastguard Worker authored
Change-Id: I872f1cb942feffbcfebb44b2aa62abed189f453e
-
- Jul 21, 2021
-
-
Jason Macnak authored
... to update ANGLE for Cuttlefish to pull in https://crrev.com/c/3018486 to fix AHardwareBufferNativeTests stencil tests. Bug: b/194147181 Test: cts -m CtsNativeHardwareTestCases Change-Id: I9857a411066dabcc6ba09bc06e6fa9e455b6e0d0
-
android-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/715a49c754fb..d2b659f9a1ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-android-autoroll Please CC jmadill@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Test: Presubmit checks will test this change. Exempt-From-Owner-Approval: The autoroll bot does not require owner approval. Bug: b/192352791 Bug: b/193828422 Change-Id: Id9fc78754d5ff82ef75a522507c30aec8fc0e4ff
-
Jeff Vigil authored
Add Validation check to Contexts and Surfaces Add Vulkan protected memory features and properties Add protected member to Surfaces and Contexts Implement hasProtectedContent in Vulkan Add QueueFamily helper, extent DeviceQueueMap Protected Swapchains always on for Android Add EGLProtectedContentTest Test: angle_end2end_test --gtest_filter=EGLProtectedContentTest Bug: angleproject:3965 Change-Id: I9352b1e594f71bb4e89cee7137a468940d186b1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800413 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- Jul 20, 2021
-
-
Shahbaz Youssefi authored
The interpolateAt* builtins take their first argument as a pointer, so only the OpAccessChain result should be given to the corresponding SPIR-V instruction. A test is written in this change to handle interpolateAt* when given a swizzled lvalue, which is not representable in SPIR-V. This can be supported by having the AST transform: interpolateAtX(value.zy) to: interpolateAtX(value).zy which can be done right when the function is parsed and the AST node for it is created (by taking the swizzle out of the parameter and applying it to the node). However, swizzled lvalues as parameter to interpolateAt* is only allowed in desktop GLSL, and so the test is disabled. From the GLSL ES3.2 spec: > Component selection operators (e.g. .xy) may not be used when > specifying interpolant. Bug: angleproject:4889 Change-Id: I043969f22011e6171c7ae225ded3a5013e8cfa4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035588 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This should fix recent permissions changes. Bug: chromium:1231092 Change-Id: Ie9b39449c861f3ab774334c4d392d1700c638ea9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3040565 Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Ivan Murashov authored
After the CL https://chromium-review.googlesource.com/c/angle/angle/+/2965780 the build with GCC failed with error: /third_party/angle/src/libANGLE/Display.h:325:37: error: declaration of 'typedef class std::__1::set<gl::Context*> egl::Display::ContextSet' changes meaning of 'ContextSet' [-fpermissive] /third_party/angle/src/libANGLE/Display.h:75:7: note: 'ContextSet' declared here as 'using ContextSet = class std::__1::set<gl::Context*>' To fix the error the double declaration of ContextSet is removed. Bug: angleproject:5878, chromium:819294 Change-Id: Id9e52061af53ea18dd5d13b960daaa67a14f61ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3038804 Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Bug: angleproject:6198 Bug: chromium:995993 Change-Id: Ib8eb640d567c63d85645f64cc870a286227fb9c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3040160 Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jeff Gilbert authored
This is more reliable and reduces reliance on build flags. Vendoring into Firefox, it's not trivial to replicate build flags, but C++-native checks always work. Bug: angleproject:6186 Change-Id: Idafd4ef1954efbfa79eae86cddfaa8f2e3992296 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036589 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c6747d98397d..7a7993b54e62 2021-07-20 capn@google.com Remove -Xclang -fuse-init-array from the Android build flags 2021-07-19 capn@google.com Move remaining Subzero x86 traits to their corresponding class 2021-07-19 capn@google.com Move Subzero Inst traits to the Inst header/source 2021-07-19 capn@google.com Move Subzero Assembler traits to the Assembler header/source 2021-07-19 capn@google.com Refactor AsmAddress creation 2021-07-19 capn@google.com Make AsmAddress producing methods static 2021-07-19 capn@google.com Increase Subzero x86-64 stack alignment to 16 2021-07-19 capn@google.com Fix RequiredStackAlignment initialization 2021-07-19 capn@google.com Rename Subzero Address to AsmAddress 2021-07-19 capn@google.com Rename Subzero traits Operand to AsmOperand 2021-07-19 capn@google.com Specialize Subzero X86 backends for 32- or 64-bit 2021-07-19 capn@google.com Don't templatize based on X86 traits 2021-07-19 capn@google.com Deduplicate X86 condition codes 2021-07-19 capn@google.com De-templatize the IceAssemblerX86Base class 2021-07-19 capn@google.com Duplicate X86 headers into X8632 and X8664 ones 2021-07-19 capn@google.com Define specialized PoolTypeConverter constants in the header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6a3818c2961e05bbfbeb5efac2ce9e495f3a832d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3040826 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/7c4121a2cfd0..a42815069bad Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/4b7b86d568..9158061398 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/be3988b13c..e51630595f * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/640b17b5fb..f084bcfe2b * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8b83ca019c..d444097efd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I32ca60c8087c6107f39ed0eb13baec3b997beaa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3040923 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
Some built-ins have out parameters; modf, frexp, uaddCarry, usubBorrow, umulExtended and imulExtended. In SPIR-V, they are translated as such: - modf and frexp: Returns the same result as GLSL, with a pointer to store the output parameter. Since SPIR-V cannot create pointers to swizzles, a temp variable is used in that case. - uaddCarry, usubBorrow, umulExtended and imulExtended: These return a struct in SPIR-V, which contains the two output parameters; with lsb in field 0 and msb in field 1. Bug: angleproject:4889 Change-Id: Ic5114f74b9c1013093007e91939f78d5218f2a07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036088 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jeff Gilbert authored
(Originally by Jeff Muizelaar <jrmuizel@gmail.com>) This lets us run WebRender on devices that only support D3D 10.0. Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1620075 Bug: angleproject:6189 Change-Id: I77c09851c50dee206702b1da25a9ef0c05eeb6c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036598 Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jeff Gilbert <jgilbert@mozilla.com>
-
Jeff Gilbert authored
Bug: angleproject:6185 Change-Id: Ia3292935489e808bc53a6df3723d81355789b460 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036588 Commit-Queue: Jeff Gilbert <jgilbert@mozilla.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
Checks for the existence of the compiler_proxy process. Bug: angleproject:6102 Change-Id: I58848dc7cd62aeb65c28990212f29df6ff66db1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989672 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Kenneth Russell authored
This set of changes: - Adds a single place (CompilerMtl::useDirectToMSLCompiler) where the direct-to-MSL compiler can be enabled, still at compile time rather than run time. It is still disabled by default. - Initializes MTLWaitableCompileEventImpl::mShader, without which all shader compiles crash. - Fixes a mismatch of the ANGLERasterizerDisabled variable name in the generated MSL. - Removes the transform feedback bindings as an argument to the vertex shader's main0(). Transform feedback support needs to be reimplemented in this compiler backend. - Added an option to the DriverUniform class to emit as either an interface block or a struct. The direct-to-MSL backend assumes it is a struct. - Disable variable reference validation when referencing either sample mask or rasterizer discard functionality in the shader. - Disable struct usage validation when inserting references to ANGLE_TextureEnv. This occurs during pipeline rewriting and it's infeasible to disable it at that point, so disable it during pipeline rewriting - which means it's disabled for all shaders. - For angle_end2end_tests, disable the file API hooking which disables the Metal shader cache. This speeds up the tests significantly - by roughly a factor of 5. With these changes, several hundred angle_end2end_tests run without any assertion failures, though still with many test failures. The next crash is in: GLSLTest.NamelessScopedStructs/ES2_Metal and will likely require a larger bug fix, or more changes to be upstreamed from WebKit's repository. Bug: angleproject:5505 Change-Id: Ia1ea9a13867f00035d4aeccf907fd032255588e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010486 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Jamie Madill authored
In preparation for a Chromium change that makes dchecks enabled by default in Release builds, we'll keep ASSERT disabled in Release by default. We add a new flag 'angle_assert_always_on' for controlling ANGLE ASSERT behaviour. Also slightly refactors the direct SPIR-V generation GN. Chromium CL: https://crrev.com/c/2893204 Bug: chromium:1225701 Change-Id: I01a6def28d7c21e771e9800889a6b9c274972de2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035447 Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Note that we do not currently expose any mutable configs. Bug: b/192352791 Change-Id: Ib97f7889fedd91d09ef32dc7e7494ea4476cd7bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035583 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Shahbaz Youssefi authored
This reverts commit 0beafe86. Reason for revert: VVL error no longer reproducible Original change's description: > Ignore VUID-VkSpecializationMapEntry-constantID-00776 > > New check added in > https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/2903 > Blocks VVL rolls. > > Bug: chromium:1226682 > Change-Id: Iaf12187c33a0c3736acae6e772277dbe6aa4c402 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007137 > Reviewed-by:
Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1226682 Change-Id: I7df7373fb52a1a64d94fd1973927cef4f89f2f05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3017555 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Torne (Richard Coles) authored
Android 12 requires all components with an <intent-filter> to explicitly specify whether they are exported, instead of being exported by default. Update various remaining cases in our tests/sample code/tools. Bug: chromium:1223110 Change-Id: Iab37881d947da25d771bf757d2f7581ad782c73f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035442 Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Mohan Maiya authored
ValidateCopyImageSubDataBase had a few missing validations and was returning the incorrect error enum. Bug: angleproject:3593 Test: dEQP-GLES31.functional.debug. negative_coverage.callbacks.buffer.copy_image_sub_data negative_coverage.log.buffer.copy_image_sub_data negative_coverage.get_error.buffer.copy_image_sub_data error_filters.case_24 Change-Id: I6f96c49ae6cf584559cb56fc614ac289b5e00c77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2970944 Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Mohan Maiya authored
1. Add a function to upload YUV image data to textures 2. Modify stageSubresourceUpdate method to account for YUV images 3. Create VkSamplerYcbcrConversion when initializing ImageHelper 4. Update hasImmutableSampler to account for native YUV format support 5. Skip initializeNonZeroMemory for YUV formats Bug: angleproject:5773 Test: Texture2DTestES3.TexStorage2D*Yuv*Vulkan* Change-Id: I270f04bbf903cf2bf19f100eb95f32953d491c39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2947767 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
- Jul 19, 2021
-
-
Jamie Madill authored
This was changed to ModuleDir in http://crrev.com/c/3035444 Fixed the capture/replay self-tests. Bug: chromium:1219969 Change-Id: Iaada421e9748db1e8afe17acf0705d5a89db6edb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035248 Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jeff Gilbert authored
Bug: angleproject:6187 Change-Id: Ife2c9f08ca213358b8fb06a858664d235a860730 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036592 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/6b9a0f391fa4..571256871c2e 2021-07-16 alexander.galazin@arm.com Use uintptr_t in the framework 2021-07-16 alexander.galazin@arm.com Use [u]int64_t in the framework 2021-07-16 gleese@broadcom.com Extend image tests to support formats with no formats 2021-07-16 gleese@broadcom.com Define a framework function for getting SPIR-V format tokens 2021-07-15 piotr.byszewski@mobica.com Test blitting from compressed formats 2021-07-15 siglesias@igalia.com Add test of vkCmdCopyImage with both layers and mipmaps 2021-07-15 rgarcia@igalia.com Test dynamic topology with tessellation shaders 2021-07-15 gleese@broadcom.com Remove extended image format capabilities from more tests 2021-07-15 gleese@broadcom.com Simplify image extend operand tests for extended formats 2021-07-15 alexander.galazin@arm.com Use [u]int16_t in the framework 2021-07-15 alexander.galazin@arm.com Use [u]int8_t in the framework 2021-07-15 alexander.galazin@arm.com Use [u]int32_t in the framework 2021-07-15 alexander.galazin@arm.com Require to enable implicit layers 2021-07-14 jajones@nvidia.com Fix FreeBSD build of VK_EXT_physical_device_drm tests 2021-07-09 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master 2021-07-09 alexander.galazin@arm.com Deprecation notice for Vulkan CTS 1.2.3.x 2021-07-09 siglesias@igalia.com Added tests to check ignored Vk*PipelineCreateInfo members If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC cnorthrop@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,angle-bots+autoroll-info@google.com Change-Id: I3be9b8f86434efa3e0f09b8de96797840b27b1f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3037214 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Jamie Madill authored
This was causing issues with a Chrome test. Bug: chromium:1230474 Change-Id: I0e5e3df5c9ad5774d6f5a2b41f4f1429000fe81e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035247 Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ba18c78e4696..c6747d98397d 2021-07-19 adrian.ratiu@collabora.corp-partner.google.com Backport LLVM fix for mallinfo deprecation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I55f120389b2c651b9f13f31e20a093210e90cb0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3037890 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Yang Gu authored
The 4th field of Intel new graphics driver will overflow soon. For example, the lastest driver version is 27.20.100.9466 and the 4th field, 9466, will meet the maximum 9999 soon. Future driver will bump the 3rd field from 100 to 101. This CL extends driver version check from 4th field to both 3rd and 4th fields. Check below 2 documents for more details. https://www.intel.com/content/www/us/en/support/articles/000005654/graphics.html https://docs.google.com/document/d/1Xm4afyGR3Ow3W2G-uig9fLQR01XzmSXeanM9OXDVhlg/edit#heading=h.k8onwbxk2ig Bug: angleproject:6138 Change-Id: Iefb1d56b48d0f08e79c329c422a6ef142b33553d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007570 Commit-Queue: Yang Gu <yang.gu@intel.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/ac347590d69b..f8ef6fcfb849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/36da2dc511..f619f21d40 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5cb305306a * tools/luci-go: git_revision:d10ff2af1182ccaad573bc5acb84a36f4c280876..git_revision:175b811c1eebfa8868ab96b58a4dc7b5bcabf756 * tools/luci-go: git_revision:d10ff2af1182ccaad573bc5acb84a36f4c280876..git_revision:175b811c1eebfa8868ab96b58a4dc7b5bcabf756 * tools/luci-go: git_revision:d10ff2af1182ccaad573bc5acb84a36f4c280876..git_revision:175b811c1eebfa8868ab96b58a4dc7b5bcabf756 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ed1db6c6b3..df951e112c * tools/skia_goldctl/linux: v3HXOS7MJkC2TfycHGZS1dHlQ_BosbzqLeuDXXLbxMUC..up6EUcZzuFZnm2JCEV1eW0TwCEAZjPcqtS2CsZN-3qAC * tools/skia_goldctl/mac: nx0V9Budj8K1DfPIdKA9oakeQE7SPTMIvVwqzX0DkF4C..eR_S1Urlw9be4WKiQcXwEcBn9KiDrWknodT82I6vw-kC * tools/skia_goldctl/win: 5vRobMZ1N26UvonRAdJZ66IEfzd3vF8r6z8j4Nqrhc8C..pLY1rCmGsL8vtV0wWxgqY3sOWkwIxuRh6PMIn_0BDcAC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I33441c8cc8defd3a974de75172e16ac403d88a3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3037212 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Cody Northrop authored
Bug: angleproject:6192 Change-Id: I853864cfce5edb78be940c6f59f22187dce7e47b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3037629 Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cody Northrop authored
Also disable the test on the Linux AMD OpenGL backend. Bug: chromium:1230024 Change-Id: I9ff2d798cf7410db55802fb86635b5d833d32284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3037628 Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
- Jul 18, 2021
-
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/ec932ff42c9b..ac347590d69b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c0b24c3c75..fd86d60f33 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2500c1d8f3..37dc929ecb * buildtools/linux64: git_revision:24e2f7df92641de0351a96096fb2c490b2436bb8..git_revision:b2d77ab1373192d1532af94b68fb8bab727b0e5b * buildtools/mac: git_revision:24e2f7df92641de0351a96096fb2c490b2436bb8..git_revision:b2d77ab1373192d1532af94b68fb8bab727b0e5b * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/486cb62885..7d5c92f6cf * buildtools/win: git_revision:24e2f7df92641de0351a96096fb2c490b2436bb8..git_revision:b2d77ab1373192d1532af94b68fb8bab727b0e5b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d5800742c1..36da2dc511 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3a5a816917..9211d9e376 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5cb305306a * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/e9e400e0af..ad8b3b0f84 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/7cf9863263..2229323ff7 * tools/luci-go: git_revision:91a04914ac71b7b6fe7b95ce8691d45eeb69bf4f..git_revision:d10ff2af1182ccaad573bc5acb84a36f4c280876 * tools/luci-go: git_revision:91a04914ac71b7b6fe7b95ce8691d45eeb69bf4f..git_revision:d10ff2af1182ccaad573bc5acb84a36f4c280876 * tools/luci-go: git_revision:91a04914ac71b7b6fe7b95ce8691d45eeb69bf4f..git_revision:d10ff2af1182ccaad573bc5acb84a36f4c280876 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8e00ef0f0d..49df801dea No update to Clang. Bug: angleproject:6182 Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I126380502db06c46d8e1ddada145a3f6f0c85b39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035951 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- Jul 17, 2021
-
-
Tim Van Patten authored
The app jp.garud.ssimulator uses the same sample count of '2' for both glRenderbufferStorageMultisampleEXT() and glFramebufferTexture2DMultisampleEXT(). However, when glRenderbufferStorageMultisampleEXT() is called, Renderbuffer::setStorageMultisample() calls TextureCaps::getNearestSamples() which rounds up the sample count from '2' to '4'. Later, when the app tries to draw with the framebuffer, an error is generated by ANGLE: Framebuffer is incomplete: Attachments have different sample counts. The fix is to also call TextureCaps::getNearestSamples() in Framebuffer::setAttachment() to make sure the sample count passed into glFramebufferTexture2DMultisampleEXT() is also rounded up to match the renderbuffer. Bug: angleproject:6183 Test: MultisampledRenderToTextureTest.FramebufferCompletenessSmallSampleCount Change-Id: I58be9986077257f4767f2e528c2f87e496d9d774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036254 Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Cody Northrop authored
The following test is failing on AMD Linux bots: GLSLTest_ES31.TypesUsedInDifferentBlockStorages/ES3_1_OpenGL It is skipped on many platforms, so adding another. Bug: chromium:1230024 Change-Id: Ie24aa04c1b8ab4d4ecdb5c4449d320ae180ecb54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035864 Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Ian Elliott authored
Change master->main and eliminate a redundant/premature Linux instruction. Bug: angleproject:0 Change-Id: Ic7171f860de8acc22050a4d4858cfd318f36b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035863 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Geoff Lang authored
This extension currently has no known users and doubles the number of entry points that ANGLE exports which is a significant binary size cost. This saves about 130kb of binary size on Android. Bug: chromium:1084580 Change-Id: Ib0fc4930b38a33bd61434f7d0030ba9fb9b93ba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3015518 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
SPIR-V doesn't allow bool in interface blocks. Another type specialization is added for this purpose, turning those bools to uint. Bug: angleproject:4889 Change-Id: I803bffcf5ea58c913d4df6e7aae3386c67901b25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3032021 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
Load the Vulkan loader ourselves and give vkGetInstanceProcAddr to volk. This allows us to always prefer loading from the current module directory instead of using the platform-specific ordering. Refactor angle::Library loading to use ModuleDir instead of ApplicationDir. CL originally authored by Geoff Lang. Bug: chromium:1219969 Change-Id: I21d1926e90fd66e1c23cea7323991ae55f3d22d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035444 Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
This will enable release ASSERTs. ASSERTs were unintentionally disabled when switching to release builds. Bug: angleproject:5133 Change-Id: Ie19e9fd02624b10283192467c4e22e3cf2b382c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035521 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-