Skip to content
Snippets Groups Projects
  1. Nov 15, 2018
  2. Oct 09, 2018
    • Pirama Arumuga Nainar's avatar
      Align __CTOR_LIST__ to 4 bytes for windows x86 · 2245cc50
      Pirama Arumuga Nainar authored
      Bug: http://b/117439724
      
      Without specifying alignment, if __CTOR_LIST__ is not aligned to 4
      bytes, we end up with garbage after the -1.  This causes access
      violations in __do_global_ctors.
      
      The 64-bit version aligns it to 8 bytes (ld/scrpittempl/pep.sc).
      
      Test: With this fix, AOSP Windows tools built with Clang + MinGW +
      libc++ no longer crash.
      
      Change-Id: I76be11a265cdcf272d740fa8715024f1f6df3e1b
      19 tags
      2245cc50
  3. Jul 18, 2018
  4. Jul 13, 2018
    • Yunlian Jiang's avatar
      Fix aarch64 --no-apply-dynamic-relocs option. · 49e1641c
      Yunlian Jiang authored
      This option is intended to make gold not apply link-time values for
      absolution relocations which have dynamic relocations emitted for
      them, in order to workaround an android dynamic loader bug in old
      versions of android.
      
      Unfortunately, it also had the side-effect of breaking debug data,
      because the dynamic relocations are not used for non-ALLOC sections,
      but the flag was also suppressing the static relocation.
      
      This fix was proposed by jyknight@ and it fixed the problem by filtering
      out non-ALLOC sections with the --no-apply-dynamic-relocs option.
      
      BUG: 70838247
      TEST: Debug info appears with --no-apply-dynamic-relocs
  5. Jul 12, 2018
  6. Jul 10, 2018
    • Logan Chien's avatar
      Fix dwarf_reader.cc for C++11 · fcb56510
      Logan Chien authored
      This commit replaces `std::make_pair<int, std::string>(dirindex, path)`
      with `std::make_pair(dirindex, path)` because C++11 replaces
      `std::make_pair<T, V>(T t, V v)` with
      `std::make_pair<T, V>(T &&t, V &&v)`.
      
      This commit removes explicit template arguments because forward
      references are only available during template arguments deduction.  If
      the explicit template arguments are specified, the argument `t` and `v`
      will become R-value references, which can not bind to an L-value.
      
      Test: It builds with clang++ (or g++) with CXXFLAGS="-std=c++11"
      Change-Id: I79eb94552445354f7e7bff02169879195c7f6283
  7. Jun 20, 2018
  8. Jun 02, 2018
  9. Jun 01, 2018
  10. Apr 07, 2018
  11. Apr 06, 2018
    • Ryan Prichard's avatar
      Windows: enable gold threading, copy libwinpthread-1.dll · 2485f18b
      Ryan Prichard authored
      Copy libwinpthread-1.dll alongside the binutils executables on Windows.
      
      The install_winpthreads function is copied from llvm_android:
      https://android.googlesource.com/toolchain/llvm_android/+/bd22d9779676661ae9571972dcd744c42c70ffd0/build.py#1063
      
      Most C++ MinGW programs need libpthread, because even libstdc++'s
      "operator new" pulls in EH code, which calls into libpthread. Currently,
      the ld.gold.exe and dwp.exe binaries need libwinpthread-1.dll, which is
      not generally in the PATH, so the binaries don't run.
      
      Previously, the Android GCC build of binutils linked ld.gold.exe and
      dwp.exe with -static, which selected the static libpthread.a. Packaging
      libwinpthread-1.dll alongside the binaries ensures that ld.gold.exe and
      the LLVMgold plugin use the same copy of the winpthreads runtime, which
      might be important.
      
      Test: ./toolchain/binutils/build.py --arch arm64 --host win64
      Test: ./toolchain/binutils/build.py  --arch arm64 --host win
      Test: ./toolchain/binutils/build.py --arch arm64  --host linux
      Test: ./toolchain/binutils/build.py --arch x86 --host win64
      Bug: none
      Change-Id: I5fc2d38b67c72fa4760be1c2688ef88479759160
      6 tags
      2485f18b
  12. Mar 28, 2018
  13. Mar 27, 2018
  14. Mar 16, 2018
  15. Mar 10, 2018
  16. Mar 09, 2018
    • Ryan Prichard's avatar
      Build binutils with --disable-nls · b01e31e3
      Ryan Prichard authored
      The --disable-nls flag is also used to build gdb and gcc for Android.
      Adding it here prevents 428 *.mo files from being added to the next NDK
      release. (AFAICT, the SDK and NDK currently have no *.mo files.) It also
      fixes a sporadic build failure that can happen when binutils needs its
      bundled copy of libintl/gettext (see build 4635300 of ab/aosp-binutils or
      the linked issue).
      
      Test: ./toolchain/binutils/build.py --arch arm --host win
      Test: ./toolchain/binutils/build.py --arch arm --host win64
      Test: ./toolchain/binutils/build.py --arch arm --host linux
      Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22941
      Change-Id: I0810406dc52f366fac7491676c2d5cb000fcfcaa
      b01e31e3
  17. Feb 28, 2018
  18. Feb 27, 2018
  19. Feb 03, 2018
Loading