Skip to content
Snippets Groups Projects
  1. Feb 07, 2016
  2. Jan 21, 2016
    • Han Shen's avatar
      Backport trunk patch wrt wrong stub generated for aarch64 large DSOs. · c327c9c1
      Han Shen authored
      Tested by build.py for linux aarch64 toolchains.
      
      The upstream patch is:
      
      commit 9a472eda40ba686e45bf4922455518ffa3c887e1
      Author: Han Shen <shenhan@google.com>
      Date:   Fri Jan 15 09:31:23 2016 -0800
      
          [gold][aarch64] PR gold/19472 - DSOs need pc-relative stubs.
      
          The stub generated during relaxation uses absolute addressing mode
          for
          shared libraries, which is not correct. Use pc-relative addressing
          instead.
      
          gold/ChangeLog:
      
          2016-01-15 Han Shen	 <shenhan@google.com>
      
      	PR gold/19472 - DSOs need pc-relative stubs.
      
      	* aarch64.cc (Reloc_stub::stub_type_for_reloc): Return
      	PC-relative stub type for DSOs and pie executables.
      
      Change-Id: Id0022975cf93600117ff5bf300b9d736d6ad1f80
      120 tags
      c327c9c1
  3. Jan 17, 2016
  4. Jan 15, 2016
    • Han Shen's avatar
      Backport trunk patch for not applying dynamic relocs. · 6579e31a
      Han Shen authored
      Note, there is a small change from the origin patch - while in the
      upstream patch, the option --no-apply-dynamic is default off, it is on
      by default in this CL.
      
      This should not bring any changes to android or chromeos, because the
      relocation value this CL changes is not used by chromeos, and is not
      used by android either (after the fix in bionic months ago).
      
      The backported patch is -
      
        commit 0eccf19f96d6218dd7c2f8d13f0546c2b942cc08
        Author: Cary Coutant <ccoutant@gmail.com>
        Date:   Thu Nov 5 12:24:14 2015 -0800
      
            Add aarch64-specific --no-apply-dynamic-relocs option.
      
            With --no-apply-dynamic-relocs on aarch64 targets, gold will not
            apply
            link-time values for absolute relocations that become dynamic
            relocations.
            This provides a workaround for broken Android dynamic linkers that
            use
            the link-time value as an extra addend to the relocation.
      
            gold/
                PR gold/19163
                * aarch64.cc (Target_aarch64::Relocate::relocate): Don't apply
                certain relocations if --no-apply-dynamic-relocs is set.
                * options.h (--apply-dynamic-relocs): New aarch64-specific
                option.
      
      Tested - build whole toolchain and built android N9 image.
      
      Change-Id: Ida524bbee2a83574cd9e78ffdad9270787327c78
      6579e31a
  5. Jan 14, 2016
  6. Jan 13, 2016
    • Han Shen's avatar
      Remove internal link in warning messages. · a95c2e5c
      Han Shen authored
      The go/unsafe-pie link should not appear in any warning messages,
      replace it with a little bit detail.
      
      Tested by building locally on ubuntu.
      
      Change-Id: I3e590108ec2c6c8917475b5d78cdabbfcf2833f7
      3 tags
      a95c2e5c
  7. Dec 20, 2015
  8. Dec 18, 2015
  9. Nov 24, 2015
  10. Nov 21, 2015
    • Han Shen's avatar
    • Han Shen's avatar
      Fix darwin build failures (because of compilation warnings). · adb604a3
      Han Shen authored
      "%ld" is the printf specifier for "long int", which is 64-bit on 64-bit
      machines, and 32-bit on 32-bit hosts. While uint64_t is always 64 bits,
      so replace it with macro "PRIu64".
      
      Tested:
        ./build.py --host "linux" --toolchain aarch64-linux-android
        ./build.py --host "linux" --toolchain arm-linux-androideabi
        ./build.py --host "linux" --toolchain mipsel-linux-android
        ./build.py --host "windows" --toolchain arm-linux-androideabi
      
      Change-Id: I9f0b322ed14e6feb7a110bfebcff963cf94d7703
      adb604a3
    • Han Shen's avatar
      Cherry pick upstream patch for aarch64 unsupported reloc. · c536bde9
      Han Shen authored
      Bug entry here - https://b.corp.google.com/u/0/issues/25642296
      
      Tested: ./build.py --host "linux" --toolchain aarch64-linux-android
      
      Upstream patch here -
      
      commit 4d2f5d5824be99326c2c3e459c298e338856d8c8
      Author: Han Shen <shenhan@google.com>
      Date:   Tue Oct 27 15:17:54 2015 -0700
      
          Patch for PR gold/19042 - unsupported reloc 311/312.
      
          gold/
      
              * aarch64.cc (Target_aarch64::Scan::local): Add support for
              reloc 311/312.
      
      Change-Id: If784460c1ebdfb2be1ebdf1486db5eb03c5240a5
      c536bde9
  11. Nov 20, 2015
  12. Nov 06, 2015
    • Lee Campbell's avatar
      Plumb --pic-veneer option for gold. · 932d71b8
      Lee Campbell authored
      Cherry-pick of upstream commit cdb061674c044636465e52a8c989b9011f2ec8ac
      
      gold/ChangeLog:
              * arm.cc (Reloc_stub::stub_type_for_reloc): Plumb to stub generation.
              * options.h (General_options): Add --pic-veneer option.
      
      BUG: 25512672
      932d71b8
  13. Nov 04, 2015
    • Nick Clifton's avatar
      Fix Mac OS X build failures (wcsncasecmp unsat) · 0a79d97a
      Nick Clifton authored
      Cherry-pick of upstream commit 31593e1b96c792abba3c5268d6423975aefa56b2
      
       2015-02-24  Nick Clifton  <nickc@redhat.com>
      
      	* configure.ac (AC_CHECK_HEADERS): Add wctype.h.
      	* configure: Regenerate.
      	* config.in: Regenerate.
      	* peXXigen.c: Include wctype.h if HAVE_WCTYPE_H is defined.
      	(u16_mbtowc): Use wint_t types if HAVE_WCTYPE_H is defined.
      	(rsrc_cmp): Use towlower instead of wcsncasecmp if HAVE_WCTYPE_H
      	is defined.
      
      Bug: 25427405
      Change-Id: I06e99d906226ce9c88ff1c568ae7a4d84df7f332
      0a79d97a
  14. Oct 16, 2015
    • Than McIntosh's avatar
      Fix gold build error at -O0. · b51d5d61
      Than McIntosh authored
      Cherrypick of upstream commit 5d7908e0880030628536a0266968a15922574735
      
        Author: Cary Coutant <ccoutant@gmail.com>
        Date:   Thu Jun 11 13:19:38 2015 -0700
      
          Fix gold build error at -O0.
      
          In aarch64.cc, Erratum_stub::STUB_ADDR_ALIGN and Reloc_stub::STUB_ADDR_ALIGN
          are declared as static const int, and initialized in the class body. These
          values are referenced from outside the class body, and with no optimization,
          the references go unresolved.
      
          gold/
              * aarch64.cc (Erratum_stub::STUB_ADDR_ALIGN): Move initialization
              outside class body.
              (Reloc_stub::STUB_ADDR_ALIGN): Likewise.
      
      Change-Id: I6c0726e624be076e0d0565652a56da5ef761d88a
      b51d5d61
  15. Sep 29, 2015
    • Han Shen's avatar
      Use "gold_info" instead of "gold_warning" for erratum fix. · 21947aa2
      Han Shen authored
      gold/ChangeLog:
      
      	* aarch64.cc (Target_aarch64::scan_erratum_843419_span): Use 'gold_info'.
      	(Target_aarch64::scan_erratum_835769_span): USe 'gold_info'.
      
      (cherry picked from commit 73854cdd438dc8858290231ebcb682377d71fec2)
      21947aa2
    • Han Shen's avatar
      Drop 'missing mapping symbols' warning for arm and aarch64. · 1c1d236d
      Han Shen authored
      The psABI (AAELF) says this about mapping symbols:
      
          4.6.5.1 Section-relative mapping symbols
      
          Mapping symbols defined in a section define a sequence of
          half-open address intervals that cover the address range of the
          section. Each interval starts at the address defined by the
          mapping symbol, and continues up to, but not including, the
          address defined by the next (in address order) mapping symbol or
          the end of the section. A section must have a mapping symbol
          defined at the beginning of the section; however, if the section
          contains only data then the mapping symbol may be omitted.
      
      That makes it pretty clear that, in the absence of a mapping symbol,
      the entire section can be treated as data.
      
      gold/ChangeLog:
      	* aarch64.cc (AArch64_relobj::scan_errata): Drop missing symbol warning.
      	* arm.cc (Arm_relobj::scan_section_for_cortex_a8_erratum): Drop missing
      	symbol warning.
      
      (cherry picked from commit 61163dfaaedb90d78e11c1d79ad1e469daf3da47)
      1c1d236d
  16. Aug 16, 2015
  17. Jul 31, 2015
    • Andrew Hsieh's avatar
      Remove duplicated option fix_cortex_a53_835769 · ef83eb2b
      Andrew Hsieh authored
      This was added before ld.gold scans for erratum 835769, but
      GCC has been hard-wired to pass "--fix-cortex-a53-835769"
      to linker (ld.bfd is default for AArch64 for now) unconditionally
      in Android platform.
      
      Change-Id: I39bacdc2a52d09afdc0993c17b46ac438d1fa246
      ef83eb2b
  18. Jul 30, 2015
    • Han Shen's avatar
      Make gold aarch64 accept long form of mapping symbols. · 0040352e
      Han Shen authored
      2015-07-07  Han Shen  <shenhan@google.com>
      
      gold/ChangeLog:
      	2015-07-06 Han Shen  <shenhan@google.com>
      	* aarch64.cc (AArch64_relobj::do_count_local_symbols): Make legal
      	of mapping symbols.
      
      Change-Id: If62f577eeb704d8c7b0b2f525e91b3cb311001ca
      (cherry picked from commit b91deca94e36b9f18156909e4c615fe7af8e3ae8)
      0040352e
    • Han Shen's avatar
      Patch for gold internal error while fixing erratum 843419. · ec8f12bc
      Han Shen authored
      The crash reason is that the insn to be moved to stub may be a
      relocation spot, so instead of placing the origin insn (that is insn
      before-relocation) to the stub, I have to place the relocated one.
      Note the relocation involved is non-pc-relative, so it is safe to move
      the relocated insn.
      
      gold/ChangeLog:
      2015-06-29  Han Shen  <shenhan@google.com>
      
          * AArch64.cc (Erratum_stub::Insn_utilities): New typedef.
          (Erratum_stub::update_erratum_insn): New method.
          (Stub_table::relocate_stubs): Modified to place relocated insn.
          (AArch64_relobj::fix_errata): Modified gold_assert.
      
      Change-Id: I9d90ac6e569bbbab086f877c7446dc6f9ea96247
      (cherry picked from commit 56b06706ebe6bb3decc674b788b6f5b243b8610d)
      ec8f12bc
    • Han Shen's avatar
      [gold][aarch64] Fix erratum 835769. · 3f3b4a87
      Han Shen authored
      gold/ChangeLog:
      
      	* aarch64.cc (AArch64_insn_utilities::BYTES_PER_INSN): Move
      	defintion outside class definition.
      	(AArch64_insn_utilities::AARCH64_ZR): New static constant.
      	(AArch64_insn_utilities::aarch64_op31): New member.
      	(AArch64_insn_utilities::aarch64_ra): New member.
      	(AArch64_insn_utilities::aarch64_mac): New member.
      	(AArch64_insn_utilities::aarch64_mlxl): New member.
      	(ST_E_835769): New global enum member.
      	(Stub_table::relocate_stubs): Add 835769 handler.
      	(Stub_template_repertoire::Stub_template_repertoire): Install new
      	stub type.
      	(AArch64_relobj::scan_errata): This func is renamed from
      	scan_erratum_843419.
      	(AArch64_relobj::do_count_local_symbols): Add 835769 handler.
      	(AArch64_relobj::do_relocate_sections): Add 835769 handler.
      	(AArch64_relobj::scan_sections_for_stubs): Add 835769 handler.
      	(Target_aarch64::scan_erratum_835769_span): New method.
      	(Target_aarch64::create_erratum_stub): New method.
      	(Target_aarch64::is_erratum_835769_sequence): New method.
      	(Target_aarch64::scan_erratum_843419_sequence): Move part of the
      	code into create_erratum_stub.
      	* options.h (fix_cortex_a53_835769): New option.
      
      Change-Id: Ia355fad38de61f82b9a42c601129fbbe2730ba27
      (cherry picked from commit 2f0c79aa61e82cbc5da4b9ab399362b2cdd8ea2e)
      3f3b4a87
    • Han Shen's avatar
      Patch for erratum-843419 (2 of 2 - fix erratum occurrences). · d3279854
      Han Shen authored
      Now fixing for 843419 is fully functional.
      
      The first part of the erratum fix CL is here -
      https://sourceware.org/ml/binutils/2015-04/msg00229.html
      
      gold/ChangeLog
      2015-06-10  Han Shen  <shenhan@google.com>
      
          * aarch64.cc(global enum): New constants representing stub types.
          (Stub_template): New POD struct.
          (Stub_template_repertoire): New class.
          (Stub_base): New class.
          (Erratum_stub): New class.
          (Reloc_stub): Refactored to be a subclass of Stub_base.
          (Reloc_stub::Stub_type): Removed.
          (Reloc_stub::offset): Moved to Stub_base.
          (Reloc_stub::set_offset): Moved to Stub_base.
          (Reloc_stub::destination_address): Moved to Stub_base.
          (Reloc_stub::set_destination_address): Moved to Stub_base.
          (Reloc_stub::reset_destination_address): Moved to Stub_base.
          (Reloc_stub::stub_type): Renamed and moved to Stub_base.
          (Reloc_stub::stub_size): Renamed and moved to Stub_base.
          (Reloc_stub::stub_insns): Renamed and moved to Stub_base.
          (Reloc_stub::write): Moved to Stub_base.
          (Reloc_stub::invalid_offset): Moved to Stub_base.
          (Reloc_stub::invalid_address): Moved to Stub_base.
          (Reloc_stub::stub_type_): Renamed and moved to Stub_base.
          (Reloc_stub::stub_insns_): Moved to Stub_base.
          (Reloc_stub::offset_): Moved to Stub_base.
          (Reloc_stub::destination_address_): Moved to Stub_base.
          (Stub_table::The_aarch64_relobj): New typedef.
          (Stub_table::The_erratum_stub): New typedef.
          (Stub_table::The_erratum_stub_less): New typedef.
          (Stub_table::The_erratum_stub_set): New typedef.
          (Stub_table::The_erratum_stub_set_iter): New typedef.
          (Stub_table::empty): Added emptiness testing for erratum stubs.
          (Stub_table::add_erratum_stub): New method to add an erratum stub.
          (Stub_table::find_erratum_stub): New method.
          (Stub_table::find_erratum_stubs_for_input_section): New method.
          (Stub_table::erratum_stub_address): New method.
          (Stub_table::update_date_size_changed_p): Modified to handle erratum stubs.
          (Stub_table::do_addralign): Modified to handle erratum stubs.
          (Stub_table::erratum_stubs_): New member.
          (Stub_table::erratum_stub_size_): New member.
          (Stub_table::relocate_stubs): Modified to handle erratum stubs.
          (Stub_table::do_write): Modified to handle erratum stubs.
          (AArch64_relobj::The_erratum_stub): New typedef.
          (AArch64_relobj::Erratum_stub_set_iter): New typedef.
          (AArch64_relobj::fix_errata): New method.
          (Target_aarch64::The_reloc_stub_type): Removed.
          (Target_aarch64::The_erratum_stub): New typede.
          (AArch64_relocate_functions::construct_b): New method.
      
      Change-Id: I37ccc9fbefd5559dae700637e119a2a885cf3eb9
      (cherry picked from commit a48d0c12f893a922692492829f04189d9f216172)
      d3279854
  19. Jul 27, 2015
    • Joseph Myers's avatar
      Fix DT_MIPS_RLD_MAP_REL tag for n64 target and 32-bit host. · 7e80b87f
      Joseph Myers authored
      Cherry-picked from upstream: d5cff5df74b18e1e5ed94de8f4c9adee3ffd95c6
      
      For the case of MIPS n64 target and 32-bit host, the computation of
      the DT_MIPS_RLD_MAP_REL tag involves sdyn->output_section->vma +
      sdyn->output_offset (64-bit) being added to b (32-bit host pointer),
      so losing the high part and resulting in an incorrect
      DT_MIPS_RLD_MAP_REL tag, and all dynamically linked glibc tests
      failing for n64.  This patch fixes this (spot-tested with glibc tests;
      however, I don't have a self-contained testcase for this bug).
      
      * elfxx-mips.c (_bfd_mips_elf_finish_dynamic_sections)
      <DT_MIPS_RLD_MAP_REL>: Add target address to host address
      difference, not to host pointer.
      
      Change-Id: If4984d632723a36a3d6c739a96706b5636f975bc
      7e80b87f
  20. Jul 15, 2015
  21. Jul 08, 2015
  22. Jun 23, 2015
  23. Jun 18, 2015
  24. Jun 17, 2015
  25. May 06, 2015
    • Andrew Hsieh's avatar
      Fix darwin build · c39479f4
      Andrew Hsieh authored
      1. In Drawin PTHREAD_ONCE_INIT is {0x30B1BCBA, {0}} and the GCC < 4.4
         doesn't support ended initializer list
      2. wcsncasecmp doesn't exist in MacSDK10.6.x
      
      Change-Id: I69204a72f853f5263dffedc448379d75ed4eca2e
      c39479f4
  26. May 05, 2015
  27. Apr 28, 2015
    • Han Shen's avatar
      Rename '--fix-cortex-a53' to '--fix-cortex-a53-843419'. · 29e2f846
      Han Shen authored
      Keep gold consistent with bfd erratum-fixing option names, so as to
      ease life in Makefile/scripts.
      
      gold/
      
      	* options.h (--fix-cortex-a53-843419): Rename option.
      	* aarch64.cc (AArch64_relobj::do_count_local_symbols): Use renamed
      	option.
      	(AArch64_relobj::scan_sections_for_stubs): Use renamed option.
      
      Change-Id: I8941fb38ef34fa5eb297e83725d87fdee994fc3a
      29e2f846
    • Han Shen's avatar
      The first patch to address cortex-a53 erratum-843419. · f2bbcbc8
      Han Shen authored
      It implemented scanning the binary and reporting occurrences to users
      when '--fix-cortex-a53' is turned on. With this, gold users will be
      able to see if or not there are such erratum occurrences in the output
      binary. Also included in the CL is reading/recording mapping symbols,
      which is needed during scan.
      
      gold/ChangeLog:
          * aarch64.cc (AArch64_insn_utilities): New utility class.
          (AArch64_relobj::Mapping_symbol_position): New struct.
          (AArch64_relobj::Mapping_symbol_info): New typedef.
          (AArch64_relobj::do_count_local_symbols): New function overriding
          parent's implementation.
          (AArch64_relobj::mapping_symbol_info_): New member
          (AArch64_relobj::scan_erratum_843419): New method.
          (Target_aarch64::scan_erratum_843419_span): New method.
          (Target_aarch64::is_erratum_843419_sequence): New method.
          * options.h (fix_cortex_a53): New option.
      
      Change-Id: I4fe7a2b8858cda358ac28eede42cd5a2f49c2238
      f2bbcbc8
  28. Apr 22, 2015
  29. Apr 21, 2015
    • Alexander Ivchenko's avatar
      [2.24, 2.25] Convert mov foo@GOT(%reg), %reg to lea foo@GOTOFF(%reg), %reg · 86097ec4
      Alexander Ivchenko authored
      
          2015-04-01  Ilya Tocar  <ilya.tocar@intel.com>
      
              PR gold/17640
              * i386.cc (Target_i386::can_convert_mov_to_lea): New.
              (Target_i386::Scan::local): Don't create GOT entry, when we
              can convert GOT to GOTOFF.
              (Target_i386::Scan::global): Ditto.
              (Target_i386::Relocate::relocate): Convert  mov foo@GOT(%reg), %reg to
              lea foo@GOTOFF(%reg), %reg if possible.
              * testsuite/Makefile.am (i386_mov_to_lea): New test.
              * testsuite/i386_mov_to_lea1.s: New.
              * testsuite/i386_mov_to_lea2.s: Ditto.
              * testsuite/i386_mov_to_lea3.s: Ditto.
              * testsuite/i386_mov_to_lea4.s: Ditto.
              * testsuite/i386_mov_to_lea5.s: Ditto.
              * testsuite/i386_mov_to_lea.sh: Ditto.
      
      Change-Id: I7916a1da20873600a910ce358990b1fe2c1f9897
      Signed-off-by: default avatarAlexander Ivchenko <alexander.ivchenko@intel.com>
      86097ec4
  30. Apr 06, 2015
Loading